Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffs are now on references not branches #863

Merged
merged 1 commit into from
Oct 25, 2020

Conversation

arielshaqed
Copy link
Contributor

See identical change to naming (but with a very long actual implementation) in 99e1bd1.

See identical change to naming (but with a very long actual implementation) in 99e1bd1.
@arielshaqed arielshaqed requested a review from nopcoder October 25, 2020 13:07
@arielshaqed arielshaqed added the pr/merge-if-approved Reviewer: please feel free to merge if no major comments label Oct 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #863 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
- Coverage   45.14%   45.10%   -0.04%     
==========================================
  Files         140      140              
  Lines       10855    10855              
==========================================
- Hits         4900     4896       -4     
- Misses       5324     5326       +2     
- Partials      631      633       +2     
Impacted Files Coverage Δ
catalog/cataloger.go 69.28% <ø> (ø)
catalog/cataloger_commit.go 76.81% <0.00%> (-5.80%) ⬇️
catalog/cataloger_create_repository.go 62.96% <0.00%> (-3.71%) ⬇️
catalog/cataloger_create_entry.go 100.00% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0454f...f7a432b. Read the comment docs.

@itaiad200 itaiad200 merged commit 1626f37 into master Oct 25, 2020
@arielshaqed
Copy link
Contributor Author

arielshaqed commented Oct 25, 2020

change parameter name in interface, coverage drops

@arielshaqed arielshaqed deleted the chore/rename-cataloger-diff-interface branch December 21, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/merge-if-approved Reviewer: please feel free to merge if no major comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants